Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2571653002:
Add a basic task switcher to the simple window manager. (Closed)
|
Created:
4 years ago by Ben Goodger (Google) Modified:
4 years ago Reviewers:
sky CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a basic task switcher to the simple window manager.
R=sky@chromium.org
Committed: https://crrev.com/88b833afe8bfdd676aa0e1415f0624d3b1b9af2d
Cr-Commit-Position: refs/heads/master@{#437968}
Patch Set 1 #
Total comments: 3
Patch Set 2 : . #Patch Set 3 : . #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by ben@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
https://codereview.chromium.org/2571653002/diff/1/mash/simple_wm/simple_wm.cc File mash/simple_wm/simple_wm.cc (right): https://codereview.chromium.org/2571653002/diff/1/mash/simple_wm/simple_wm.cc... mash/simple_wm/simple_wm.cc:46: window_container_->RemoveObserver(this); Remove observers from windows_? https://codereview.chromium.org/2571653002/diff/1/mash/simple_wm/simple_wm.cc... mash/simple_wm/simple_wm.cc:139: return gfx::Size(0, height); Don't you want to increment width rather than height? At least your layout function uses width. That said, you may be able to use BoxLayout directly. I'm ok either way.
https://codereview.chromium.org/2571653002/diff/1/mash/simple_wm/simple_wm.cc File mash/simple_wm/simple_wm.cc (right): https://codereview.chromium.org/2571653002/diff/1/mash/simple_wm/simple_wm.cc... mash/simple_wm/simple_wm.cc:46: window_container_->RemoveObserver(this); On 2016/12/12 23:16:07, sky wrote: > Remove observers from windows_? Done.
The CQ bit was checked by ben@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ben@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/2571653002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481588304381780,
"parent_rev": "0f8d29e9b450a3a02f51832402d90062f08fcbc2", "commit_rev":
"4e0ea66ae19bc8930fcefd692aa12e6378df6192"}
Message was sent while issue was closed.
Description was changed from ========== Add a basic task switcher to the simple window manager. R=sky@chromium.org ========== to ========== Add a basic task switcher to the simple window manager. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2571653002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a basic task switcher to the simple window manager. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2571653002 ========== to ========== Add a basic task switcher to the simple window manager. R=sky@chromium.org Committed: https://crrev.com/88b833afe8bfdd676aa0e1415f0624d3b1b9af2d Cr-Commit-Position: refs/heads/master@{#437968} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/88b833afe8bfdd676aa0e1415f0624d3b1b9af2d Cr-Commit-Position: refs/heads/master@{#437968} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
