Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 2571613003: [sensors](CrOS/Linux) Add support for als sensor which has "intensity" naming. (Closed)

Created:
4 years ago by maksims (do not use this acc)
Modified:
4 years ago
CC:
chromium-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors](CrOS/Linux) Add support for als sensor which has "intensity" naming. This CL adds support for an als sensor that has "in_intensity_both_raw" naming. What is more, frequency and offset file names are added as well. Unittests were changed as well - there is no need to separately delete a frequency file now in order to receive OnSensorReadingChanged event. A zero value can be used which means "file must not be created" BUG=670602 Committed: https://crrev.com/1dcb638f139dd8557d992d81d40cbe5cc942887e Cr-Commit-Position: refs/heads/master@{#439571}

Patch Set 1 #

Patch Set 2 : correct apply_scaling_value formula #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -51 lines) Patch
M device/generic_sensor/linux/sensor_data_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/generic_sensor/linux/sensor_data_linux.cc View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 2 6 chunks +29 lines, -41 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
maksims (do not use this acc)
please take a look
4 years ago (2016-12-13 11:03:20 UTC) #7
Mikhail
lgtm
4 years ago (2016-12-19 08:21:56 UTC) #14
Reilly Grant (use Gerrit)
lgtm
4 years ago (2016-12-19 19:07:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571613003/50001
4 years ago (2016-12-19 20:28:17 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:50001)
4 years ago (2016-12-19 21:30:31 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-19 21:33:22 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1dcb638f139dd8557d992d81d40cbe5cc942887e
Cr-Commit-Position: refs/heads/master@{#439571}

Powered by Google App Engine
This is Rietveld 408576698