Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2571603003:
Worker: Add unittests for UseCounter on DedicatedWorkerGlobalScope (Closed)
|
Created:
4 years ago by nhiroki Modified:
4 years ago Reviewers:
falken CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Add unittests for UseCounter on DedicatedWorkerGlobalScope
BUG=667357
Committed: https://crrev.com/6b040dc1539e1dc96499e2050c9cf02551ac3cae
Cr-Commit-Position: refs/heads/master@{#438760}
Patch Set 1 #
Total comments: 4
Patch Set 2 : add test expectations for console messages #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
nhiroki@chromium.org changed reviewers: + falken@chromium.org
PTAL, thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2571603003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp (right): https://codereview.chromium.org/2571603003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:112: // Do nothing: just for canceling the default behavior. Why cancel? Does it get captured in the test log somehow? Can you expand? https://codereview.chromium.org/2571603003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:406: // Deprecated API use on the DedicatedWorkerlobalScope should be recorded in typo: Workerlobal
Updated. Can you take another look? Thanks! https://codereview.chromium.org/2571603003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp (right): https://codereview.chromium.org/2571603003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:112: // Do nothing: just for canceling the default behavior. On 2016/12/14 07:23:55, falken wrote: > Why cancel? Does it get captured in the test log somehow? Can you expand? Made the test initialize the inspector proxy, removed this override and added test expectations for deprecation messages. https://codereview.chromium.org/2571603003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp:406: // Deprecated API use on the DedicatedWorkerlobalScope should be recorded in On 2016/12/14 07:23:55, falken wrote: > typo: Workerlobal Done.
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by nhiroki@chromium.org
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481778652703550,
"parent_rev": "3689fb0c3a4a4f15029db1f7d84ad0dcfeb4a22f", "commit_rev":
"0100563a20631909be9c11c6cc308687f8b314c4"}
Message was sent while issue was closed.
Description was changed from ========== Worker: Add unittests for UseCounter on DedicatedWorkerGlobalScope BUG=667357 ========== to ========== Worker: Add unittests for UseCounter on DedicatedWorkerGlobalScope BUG=667357 Review-Url: https://codereview.chromium.org/2571603003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Add unittests for UseCounter on DedicatedWorkerGlobalScope BUG=667357 Review-Url: https://codereview.chromium.org/2571603003 ========== to ========== Worker: Add unittests for UseCounter on DedicatedWorkerGlobalScope BUG=667357 Committed: https://crrev.com/6b040dc1539e1dc96499e2050c9cf02551ac3cae Cr-Commit-Position: refs/heads/master@{#438760} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6b040dc1539e1dc96499e2050c9cf02551ac3cae Cr-Commit-Position: refs/heads/master@{#438760} |
