Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2571603002: Makes wait-for-debugger=content_browser work for mash (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes wait-for-debugger=content_browser work for mash This changes the command line switch "n" to "process-service-name" and makes mash-runner look for it. BUG=none TEST=none R=rockot@chromium.org Committed: https://crrev.com/2ee428f6556f670b5a05b92f23881576e4fbddcb Cr-Commit-Position: refs/heads/master@{#437999}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M chrome/app/chrome_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/mash/mash_runner.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 4 chunks +23 lines, -0 lines 0 comments Download
M services/service_manager/runner/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/runner/common/switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M services/service_manager/runner/host/child_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
sky
4 years ago (2016-12-12 21:11:13 UTC) #1
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-12 21:12:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571603002/1
4 years ago (2016-12-12 21:18:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/354659)
4 years ago (2016-12-12 23:54:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571603002/20001
4 years ago (2016-12-13 00:42:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 02:48:15 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 02:51:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ee428f6556f670b5a05b92f23881576e4fbddcb
Cr-Commit-Position: refs/heads/master@{#437999}

Powered by Google App Engine
This is Rietveld 408576698