Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 25716004: Revert 226547 "Refactor LauncherItemController and LauncherItemD..." (Closed)

Created:
7 years, 2 months ago by dcheng
Modified:
7 years, 2 months ago
Reviewers:
simonhong_
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 226547 "Refactor LauncherItemController and LauncherItemD..." > Refactor LauncherItemController and LauncherItemDelegate > > * Remove LauncherItem parameter of LauncherItemDelegate method > * LauncherItemController subclasses LauncherItemDelegate > * Register/Unregister when LauncherItemDelegate is created/removed > * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID > * LauncherItemDelegateManager take ownership of all LauncherItemDelegate > > R=sky@chromium.org, skuhne@chromium.org > BUG=279105 > TEST=unit_tests, browser_tests, ash_unittests, ash_shell > > Review URL: https://codereview.chromium.org/23606016 TBR=simon.hong81@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -809 lines) Patch
M trunk/src/ash/ash.gyp View 4 chunks +1 line, -14 lines 0 comments Download
M trunk/src/ash/launcher/launcher.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/ash/launcher/launcher_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/launcher/launcher_item_delegate.h View 3 chunks +14 lines, -9 lines 0 comments Download
M trunk/src/ash/launcher/launcher_item_delegate_manager.h View 1 chunk +20 lines, -42 lines 0 comments Download
M trunk/src/ash/launcher/launcher_item_delegate_manager.cc View 1 chunk +10 lines, -51 lines 0 comments Download
M trunk/src/ash/launcher/launcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/launcher/launcher_view.cc View 8 chunks +18 lines, -21 lines 0 comments Download
M trunk/src/ash/launcher/launcher_view_unittest.cc View 8 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/ash/shelf/app_list_shelf_item_delegate.h View 1 chunk +9 lines, -5 lines 0 comments Download
M trunk/src/ash/shelf/app_list_shelf_item_delegate.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M trunk/src/ash/shell.h View 3 chunks +3 lines, -1 line 0 comments Download
M trunk/src/ash/shell.cc View 3 chunks +3 lines, -22 lines 0 comments Download
M trunk/src/ash/shell/launcher_delegate_impl.h View 3 chunks +16 lines, -1 line 0 comments Download
M trunk/src/ash/shell/launcher_delegate_impl.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M trunk/src/ash/shell/window_watcher.cc View 3 chunks +1 line, -10 lines 0 comments Download
D trunk/src/ash/shell/window_watcher_launcher_item_delegate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D trunk/src/ash/shell/window_watcher_launcher_item_delegate.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D trunk/src/ash/test/launcher_item_delegate_manager_test_api.h View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/ash/test/launcher_item_delegate_manager_test_api.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M trunk/src/ash/test/test_launcher_delegate.h View 3 chunks +16 lines, -0 lines 0 comments Download
M trunk/src/ash/test/test_launcher_delegate.cc View 5 chunks +53 lines, -8 lines 0 comments Download
D trunk/src/ash/test/test_launcher_item_delegate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D trunk/src/ash/test/test_launcher_item_delegate.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h View 1 chunk +4 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 6 chunks +19 lines, -46 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h View 1 chunk +3 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 4 chunks +29 lines, -48 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 8 chunks +20 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 16 chunks +71 lines, -36 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 9 chunks +15 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 22 chunks +20 lines, -76 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/launcher_item_controller.h View 4 chunks +15 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h View 2 chunks +6 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 4 chunks +40 lines, -67 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
7 years, 2 months ago (2013-10-02 22:13:01 UTC) #1
dcheng
Committed patchset #1 manually as r226580.
7 years, 2 months ago (2013-10-02 22:14:05 UTC) #2
simonhong_
7 years, 2 months ago (2013-10-03 01:05:46 UTC) #3
Message was sent while issue was closed.
On 2013/10/02 22:14:05, dcheng wrote:
> Committed patchset #1 manually as r226580.

Thank you for this.
It is strange why this doesn't happen when I was landing...

Powered by Google App Engine
This is Rietveld 408576698