Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: trunk/src/ash/launcher/launcher_view_unittest.cc

Issue 25716004: Revert 226547 "Refactor LauncherItemController and LauncherItemD..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ash/launcher/launcher_view.cc ('k') | trunk/src/ash/shelf/app_list_shelf_item_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ash/launcher/launcher_view_unittest.cc
===================================================================
--- trunk/src/ash/launcher/launcher_view_unittest.cc (revision 226578)
+++ trunk/src/ash/launcher/launcher_view_unittest.cc (working copy)
@@ -11,7 +11,6 @@
#include "ash/launcher/launcher.h"
#include "ash/launcher/launcher_button.h"
#include "ash/launcher/launcher_icon_observer.h"
-#include "ash/launcher/launcher_item_delegate_manager.h"
#include "ash/launcher/launcher_model.h"
#include "ash/launcher/launcher_tooltip_manager.h"
#include "ash/launcher/launcher_types.h"
@@ -25,7 +24,6 @@
#include "ash/test/launcher_view_test_api.h"
#include "ash/test/shell_test_api.h"
#include "ash/test/test_launcher_delegate.h"
-#include "ash/test/test_launcher_item_delegate.h"
#include "base/basictypes.h"
#include "base/command_line.h"
#include "base/compiler_specific.h"
@@ -214,10 +212,6 @@
test_api_.reset(new LauncherViewTestAPI(launcher_view_));
test_api_->SetAnimationDuration(1); // Speeds up animation for test.
- item_manager_ =
- ash::Shell::GetInstance()->launcher_item_delegate_manager();
- DCHECK(item_manager_);
-
// Add browser shortcut launcher item at index 0 for test.
AddBrowserShortcut();
}
@@ -228,19 +222,12 @@
}
protected:
- void CreateAndSetLauncherItemDelegateForID(LauncherID id) {
- scoped_ptr<LauncherItemDelegate> delegate(
- new ash::test::TestLauncherItemDelegate(NULL));
- item_manager_->SetLauncherItemDelegate(id, delegate.Pass());
- }
-
LauncherID AddBrowserShortcut() {
LauncherItem browser_shortcut;
browser_shortcut.type = TYPE_BROWSER_SHORTCUT;
LauncherID id = model_->next_id();
model_->AddAt(browser_index_, browser_shortcut);
- CreateAndSetLauncherItemDelegateForID(id);
test_api_->RunMessageLoopUntilAnimationsDone();
return id;
}
@@ -252,7 +239,6 @@
LauncherID id = model_->next_id();
model_->Add(item);
- CreateAndSetLauncherItemDelegateForID(id);
test_api_->RunMessageLoopUntilAnimationsDone();
return id;
}
@@ -270,7 +256,6 @@
LauncherID id = model_->next_id();
model_->Add(item);
- CreateAndSetLauncherItemDelegateForID(id);
return id;
}
@@ -281,7 +266,6 @@
LauncherID id = model_->next_id();
model_->Add(item);
- CreateAndSetLauncherItemDelegateForID(id);
return id;
}
@@ -402,7 +386,6 @@
LauncherModel* model_;
internal::LauncherView* launcher_view_;
int browser_index_;
- LauncherItemDelegateManager* item_manager_;
scoped_ptr<LauncherViewTestAPI> test_api_;
« no previous file with comments | « trunk/src/ash/launcher/launcher_view.cc ('k') | trunk/src/ash/shelf/app_list_shelf_item_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698