Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2571583004: MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior (Closed)

Created:
4 years ago by tsergeant
Modified:
4 years ago
Reviewers:
dpapad
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, dbeam+watch-elements_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior <cr-search-field> is currently unused and can be deleted. Once it is removed, <cr-toolbar-search-field> is the only client of the behavior which needs the show/hide functionality. This CL moves that functionality into <cr-toolbar-search-field>, simplifying CrSearchFieldBehavior to be general utilities for search fields. BUG=665700 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da Cr-Commit-Position: refs/heads/master@{#438430}

Patch Set 1 #

Patch Set 2 : Vulc #

Total comments: 5

Patch Set 3 : Use focus_() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -213 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/compiled_resources2.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/webui/resources/cr_elements/cr_search_field/cr_search_field.css View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js View 4 chunks +2 lines, -48 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js View 1 2 5 chunks +45 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
tsergeant
PTAL, thanks
4 years ago (2016-12-13 04:39:09 UTC) #9
dpapad
https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js (right): https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js#newcode8 ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:8: behaviors: [CrSearchFieldBehavior], After this CL, I don't think there ...
4 years ago (2016-12-13 20:02:58 UTC) #10
tsergeant
https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js (right): https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js#newcode8 ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:8: behaviors: [CrSearchFieldBehavior], On 2016/12/13 20:02:58, dpapad wrote: > After ...
4 years ago (2016-12-14 00:05:55 UTC) #11
dpapad
LGTM! https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js (right): https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js#newcode8 ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:8: behaviors: [CrSearchFieldBehavior], > <settings-subpage-search> uses it in a ...
4 years ago (2016-12-14 03:07:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571583004/40001
4 years ago (2016-12-14 03:10:15 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 04:22:37 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-14 04:26:10 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da
Cr-Commit-Position: refs/heads/master@{#438430}

Powered by Google App Engine
This is Rietveld 408576698