MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da
Cr-Commit-Position: refs/heads/master@{#438430}

[tsergeant, 2016-12-13 02:44:35]

Description was changed from

==========
MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
==========

to

==========
MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-12-13 02:44:47]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 02:45:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-12-13 02:50:44]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 02:51:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 04:06:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:06:46]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-12-13 04:39:09]

tsergeant@chromium.org changed reviewers:
+ dpapad@chromium.org

[tsergeant, 2016-12-13 04:39:09]

PTAL, thanks

[dpapad, 2016-12-13 20:02:58]

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
(right):

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:8:
behaviors: [CrSearchFieldBehavior],
After this CL, I don't think there is any other usage of CrSearchFieldBehavior.
Is there a benefit of maintaining that separation?

Can we simply remove the behavior and move the logic here (so that it is all in
one place)?

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:155:
this.getSearchInput().focus();
Nit: Re-use
this.focus_();

[tsergeant, 2016-12-14 00:05:55]

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
(right):

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:8:
behaviors: [CrSearchFieldBehavior],
On 2016/12/13 20:02:58, dpapad wrote:
> After this CL, I don't think there is any other usage of
CrSearchFieldBehavior.
> Is there a benefit of maintaining that separation?
> 
> Can we simply remove the behavior and move the logic here (so that it is all
in
> one place)?

<settings-subpage-search> uses it in a pretty basic way. I'm unsure whether it's
worth keeping the behavior for that, or whether we should split the two apart.

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:155:
this.getSearchInput().focus();
On 2016/12/13 20:02:58, dpapad wrote:
> Nit: Re-use
> this.focus_();

Done.

[dpapad, 2016-12-14 03:07:07]

LGTM!

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
(right):

https://codereview.chromium.org/2571583004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js:8:
behaviors: [CrSearchFieldBehavior],
> <settings-subpage-search> uses it in a pretty basic way. I'm unsure whether
it's worth keeping the behavior for that, or whether we should split the two
apart.

I see. I guess we can evaluate this separately after this CL lands.

[tsergeant, 2016-12-14 03:09:45]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-12-14 03:10:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 04:22:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481684985973280,
"parent_rev": "eba33f83c0768982a081bd9a6f9cc92a5904f312", "commit_rev":
"256a99b09bc4cd8cca49421aefb569cbc96bfb0f"}

[commit-bot: I haz the power, 2016-12-14 04:22:36]

Description was changed from

==========
MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2571583004
==========

[commit-bot: I haz the power, 2016-12-14 04:22:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 04:26:09]

Description was changed from

==========
MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2571583004
==========

to

==========
MD WebUI: Delete cr-search-field, simplify CrSearchFieldBehavior

<cr-search-field> is currently unused and can be deleted. Once it is
removed, <cr-toolbar-search-field> is the only client of the behavior
which needs the show/hide functionality. This CL moves that
functionality into <cr-toolbar-search-field>, simplifying
CrSearchFieldBehavior to be general utilities for search fields.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da
Cr-Commit-Position: refs/heads/master@{#438430}
==========

[commit-bot: I haz the power, 2016-12-14 04:26:10]

Patchset 3 (id:??) landed as
https://crrev.com/a4f6b5562dcab9cc11d8d0381022bc85a40277da
Cr-Commit-Position: refs/heads/master@{#438430}