Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2571573002: Updated the return of GetBudget to a sequence (Closed)

Created:
4 years ago by harkness
Modified:
4 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated the return of GetBudget to a sequence The proposed spec for BudgetAPI defines the return value for getBudget to be a Promise that resolves with a sequence<BudgetState> while the current interface used a FrozenArray. This patch updates the code to match the proposed spec. The implementation works with either version, and this is covered by existing LayoutTests. BUG=672112 Committed: https://crrev.com/44433c83d095d50a6c46fa6a912156bfbfada092 Cr-Commit-Position: refs/heads/master@{#438127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/budget/BudgetService.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
harkness
4 years ago (2016-12-12 18:34:13 UTC) #2
Peter Beverloo
lgtm
4 years ago (2016-12-12 18:35:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571573002/1
4 years ago (2016-12-13 09:52:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 11:36:28 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-13 11:39:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44433c83d095d50a6c46fa6a912156bfbfada092
Cr-Commit-Position: refs/heads/master@{#438127}

Powered by Google App Engine
This is Rietveld 408576698