ui/keyboard/keyboard_controller_proxy.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/keyboard_controller_proxy.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/keyboard/keyboard_controller_proxy.cc

diff --git a/ui/keyboard/keyboard_controller_proxy.cc b/ui/keyboard/keyboard_controller_proxy.cc

index 4a0dd4f6fe2010ffc0e83b42ee05e488e4b5f9e5..2ade09d540bc80346b675ddf5ea0f05319261210 100644

--- a/ui/keyboard/keyboard_controller_proxy.cc

+++ b/ui/keyboard/keyboard_controller_proxy.cc

@@ -68,7 +68,7 @@ class KeyboardContentsDelegate : public content::WebContentsDelegate,

}

// Overridden from content::WebContentsObserver:

- virtual void WebContentsDestroyed(content::WebContents* contents) OVERRIDE {

+ virtual void WebContentsDestroyed() OVERRIDE {

delete this;

}

« content/public/browser/web_contents_observer.h ('K') | « content/shell/browser/webkit_test_controller.cc ('k') | no next file » | no next file with comments »