content/shell/browser/webkit_test_controller.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/webkit_test_controller.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/web_contents_observer.h ('K') | « content/shell/browser/webkit_test_controller.h ('k') | ui/keyboard/keyboard_controller_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/webkit_test_controller.cc

diff --git a/content/shell/browser/webkit_test_controller.cc b/content/shell/browser/webkit_test_controller.cc

index 3256b20d3fe97e8260da38c6c377b79a9bb36c2d..fa56d01cfb99fb1806a14bc8431e91f15926649a 100644

--- a/content/shell/browser/webkit_test_controller.cc

+++ b/content/shell/browser/webkit_test_controller.cc

@@ -421,7 +421,7 @@ void WebKitTestController::RenderProcessGone(base::TerminationStatus status) {

DiscardMainWindow();

}

-void WebKitTestController::WebContentsDestroyed(WebContents* web_contents) {

+void WebKitTestController::WebContentsDestroyed() {

DCHECK(CalledOnValidThread());

printer_->AddErrorMessage("FAIL: main window was destroyed");

DiscardMainWindow();

« content/public/browser/web_contents_observer.h ('K') | « content/shell/browser/webkit_test_controller.h ('k') | ui/keyboard/keyboard_controller_proxy.cc » ('j') | no next file with comments »