chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_observer.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index d0510b6bde096bdc53213874e7ee8a85764fbd46..62ded4165e72bb1a3f6274742f689fa80e0fb17b 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -426,7 +426,7 @@ class CurrentHistoryCleaner : public content::WebContentsObserver {

virtual ~CurrentHistoryCleaner();

// content::WebContentsObserver:

- virtual void WebContentsDestroyed(content::WebContents* contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

virtual void DidCommitProvisionalLoadForFrame(

int64 frame_id,

const base::string16& frame_unique_name,

@@ -479,8 +479,7 @@ void CurrentHistoryCleaner::DidCommitProvisionalLoadForFrame(

}

-void CurrentHistoryCleaner::WebContentsDestroyed(

- content::WebContents* contents) {

+void CurrentHistoryCleaner::WebContentsDestroyed() {

delete this; // Failure.

}