chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

index 987077be01d2b7a690c8683d24ec5ac1872aab13..a7ef731c8899de0ce6f22518261bb6deda1a61f7 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

@@ -88,10 +88,9 @@ void ManagePasswordsBubbleUIController::OnBlacklistBlockedAutofill() {

UpdateBubbleAndIconVisibility();

}

-void ManagePasswordsBubbleUIController::WebContentsDestroyed(

- content::WebContents* web_contents) {

+void ManagePasswordsBubbleUIController::WebContentsDestroyed() {

password_manager::PasswordStore* password_store =

- GetPasswordStore(web_contents);

+ GetPasswordStore(web_contents());

if (password_store)

password_store->RemoveObserver(this);

}