chrome/browser/translate/translate_tab_helper.h - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/web_contents_resource_provider.cc ('k') | chrome/browser/translate/translate_tab_helper.cc » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_tab_helper.h

diff --git a/chrome/browser/translate/translate_tab_helper.h b/chrome/browser/translate/translate_tab_helper.h

index d4195f46ca65054a876e9bec1bfdfcee59e885c0..10fb138aa9fe6ed2565fcdc9311d6bc5d69c5b23 100644

--- a/chrome/browser/translate/translate_tab_helper.h

+++ b/chrome/browser/translate/translate_tab_helper.h

@@ -108,8 +108,7 @@ class TranslateTabHelper

virtual void DidNavigateAnyFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) OVERRIDE;

- virtual void WebContentsDestroyed(

- content::WebContents* web_contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

// Initiates translation once the page is finished loading.

void InitiateTranslation(const std::string& page_lang, int attempt);