chrome/browser/task_manager/web_contents_resource_provider.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/web_contents_resource_provider.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/web_contents_resource_provider.cc

diff --git a/chrome/browser/task_manager/web_contents_resource_provider.cc b/chrome/browser/task_manager/web_contents_resource_provider.cc

index b29dd88c76e0c3ca9a5e127866e271567d12b226..2fb79f1245282f40f6fa56bd6271cb1229972456 100644

--- a/chrome/browser/task_manager/web_contents_resource_provider.cc

+++ b/chrome/browser/task_manager/web_contents_resource_provider.cc

@@ -51,8 +51,8 @@ class TaskManagerWebContentsObserver : public content::WebContentsObserver {

provider_->RemoveFromTaskManager(web_contents());

}

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE {

- provider_->RemoveFromTaskManager(web_contents);

+ virtual void WebContentsDestroyed() OVERRIDE {

+ provider_->RemoveFromTaskManager(web_contents());

provider_->DeleteObserver(this); // Deletes |this|.

}