chrome/browser/history/history_tab_helper.h - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_tab_helper.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_tab_helper.h

diff --git a/chrome/browser/history/history_tab_helper.h b/chrome/browser/history/history_tab_helper.h

index 65c21ad3b63d0cb7a70a17caf3733a16b9baa17b..c6372b4b7a7c62f43ebc2fa00a0643988da166af 100644

--- a/chrome/browser/history/history_tab_helper.h

+++ b/chrome/browser/history/history_tab_helper.h

@@ -51,7 +51,7 @@ class HistoryTabHelper : public content::WebContentsObserver,

const content::FrameNavigateParams& params) OVERRIDE;

virtual void TitleWasSet(content::NavigationEntry* entry,

bool explicit_set) OVERRIDE;

- virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

// Helper function to return the history service. May return NULL.

HistoryService* GetHistoryService();