chrome/browser/guest_view/web_view/web_view_guest.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.h ('k') | chrome/browser/history/history_tab_helper.h » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/web_view_guest.cc

diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc

index c964e87f9e8303773628bdc2a96b8504132922eb..0018b4548f4bd60c2a45dc30f0e9bc2ec4f9a03f 100644

--- a/chrome/browser/guest_view/web_view/web_view_guest.cc

+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc

@@ -789,14 +789,14 @@ void WebViewGuest::DidStopLoading(content::RenderViewHost* render_view_host) {

DispatchEvent(new GuestViewBase::Event(webview::kEventLoadStop, args.Pass()));

}

-void WebViewGuest::WebContentsDestroyed(WebContents* web_contents) {

+void WebViewGuest::WebContentsDestroyed() {

// Clean up custom context menu items for this guest.

extensions::MenuManager* menu_manager = extensions::MenuManager::Get(

Profile::FromBrowserContext(browser_context()));

menu_manager->RemoveAllContextItems(extensions::MenuItem::ExtensionKey(

embedder_extension_id(), view_instance_id()));

- RemoveWebViewFromExtensionRendererState(web_contents);

+ RemoveWebViewFromExtensionRendererState(web_contents());

}

void WebViewGuest::UserAgentOverrideSet(const std::string& user_agent) {