content/browser/web_contents/web_contents_impl.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « content/browser/media/capture/web_contents_video_capture_device.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 7d86a5f1a41ce65328c2513e5c5e0547c3f5052f..ccc97aafd86ee09efd7cd275cc402d06d9b3a8bc 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -289,8 +289,9 @@ class WebContentsImpl::DestructionObserver : public WebContentsObserver {

}

// WebContentsObserver:

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE {

- owner_->OnWebContentsDestroyed(static_cast<WebContentsImpl*>(web_contents));

+ virtual void WebContentsDestroyed() OVERRIDE {

+ owner_->OnWebContentsDestroyed(

+ static_cast<WebContentsImpl*>(web_contents()));

}

private:

@@ -419,7 +420,11 @@ WebContentsImpl::~WebContentsImpl() {

FOR_EACH_OBSERVER(WebContentsObserver,

observers_,

- WebContentsImplDestroyed());

+ WebContentsDestroyed());

+ FOR_EACH_OBSERVER(WebContentsObserver,

+ observers_,

+ WebContentsDestroyedPrivate());

SetDelegate(NULL);