Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index 15a232db6d1eb984d4406bdae578173f83f2c9fb..c6a54086cf34385972f2c3bf5626b16fb5e27be6 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -360,14 +360,7 @@ void InterstitialPageImpl::WebContentsWillBeDestroyed() {
OnNavigatingAwayOrTabClosing();
}
-void InterstitialPageImpl::WebContentsDestroyed(WebContents* web_contents) {
- // WebContentsImpl will only call WebContentsWillBeDestroyed for interstitial
- // pages that it knows about, pages that called
- // WebContentsImpl::AttachInterstitialPage. But it's possible to have an
- // interstitial page that never progressed that far. In that case, ensure that
- // this interstitial page is destroyed. (And if it was attached, and
- // OnNavigatingAwayOrTabClosing was called, it's safe to call
- // OnNavigatingAwayOrTabClosing twice.)
+void InterstitialPageImpl::WebContentsDestroyed() {
OnNavigatingAwayOrTabClosing();
}

Powered by Google App Engine
This is Rietveld 408576698