Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | components/web_modal/web_contents_modal_dialog_manager.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_modal/web_contents_modal_dialog_manager.h
diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h
index fd2d925d026b1461777364d4ed9ea4b0fdac9e51..326b4c14a10ab5cbf2c9939be78c0a7282a29013 100644
--- a/components/web_modal/web_contents_modal_dialog_manager.h
+++ b/components/web_modal/web_contents_modal_dialog_manager.h
@@ -110,7 +110,7 @@ class WebContentsModalDialogManager
virtual void DidGetIgnoredUIEvent() OVERRIDE;
virtual void WasShown() OVERRIDE;
virtual void WasHidden() OVERRIDE;
- virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
+ virtual void WebContentsDestroyed() OVERRIDE;
virtual void DidAttachInterstitialPage() OVERRIDE;
// Delegate for notifying our owner about stuff. Not owned by us.
« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | components/web_modal/web_contents_modal_dialog_manager.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698