Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6576)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index 670a864ae63054b78cdea6fc1506fbcb26a35060..902313a0853435bf8f03921ca8824698d5353f8f 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -140,8 +140,7 @@ void PermissionBubbleManager::NavigationEntryCommitted(
}
}
-void PermissionBubbleManager::WebContentsDestroyed(
- content::WebContents* web_contents) {
+void PermissionBubbleManager::WebContentsDestroyed() {
// If the web contents has been destroyed, do not attempt to notify
// the requests of any changes - simply close the bubble.
CancelPendingQueue();
@@ -150,7 +149,7 @@ void PermissionBubbleManager::WebContentsDestroyed(
// The WebContents is going away; be aggressively paranoid and delete
// ourselves lest other parts of the system attempt to add permission bubbles
// or use us otherwise during the destruction.
- web_contents->RemoveUserData(UserDataKey());
+ web_contents()->RemoveUserData(UserDataKey());
// That was the equivalent of "delete this". This object is now destroyed;
// returning from this function is the only safe thing to do.
}

Powered by Google App Engine
This is Rietveld 408576698