Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_tab_helper.h ('k') | chrome/browser/ui/android/infobars/auto_login_prompter.h » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_tab_helper.cc
diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc
index 9af958f7b6ceab7d2bbc68d2d7b953519b537c24..5ecd089f4aeea67356d65fa06a5ef40822c142db 100644
--- a/chrome/browser/translate/translate_tab_helper.cc
+++ b/chrome/browser/translate/translate_tab_helper.cc
@@ -301,8 +301,7 @@ void TranslateTabHelper::DidNavigateAnyFrame(
translate_driver_.DidNavigate(details);
}
-void TranslateTabHelper::WebContentsDestroyed(
- content::WebContents* web_contents) {
+void TranslateTabHelper::WebContentsDestroyed() {
// Translation process can be interrupted.
// Destroying the TranslateManager now guarantees that it never has to deal
// with NULL WebContents.
« no previous file with comments | « chrome/browser/translate/translate_tab_helper.h ('k') | chrome/browser/ui/android/infobars/auto_login_prompter.h » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698