chrome/browser/extensions/extension_view_host.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view_host.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('k') | chrome/browser/extensions/script_executor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_view_host.cc

diff --git a/chrome/browser/extensions/extension_view_host.cc b/chrome/browser/extensions/extension_view_host.cc

index b5ace6b79ff67a1af4dce5e33af548936218cc7f..12afaccfe882fe81504ebd715e5d2bf9b6f17989 100644

--- a/chrome/browser/extensions/extension_view_host.cc

+++ b/chrome/browser/extensions/extension_view_host.cc

@@ -42,7 +42,7 @@ class ExtensionViewHost::AssociatedWebContentsObserver

virtual ~AssociatedWebContentsObserver() {}

// content::WebContentsObserver:

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE {

+ virtual void WebContentsDestroyed() OVERRIDE {

// Deleting |this| from here is safe.

host_->SetAssociatedWebContents(NULL);

}

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('k') | chrome/browser/extensions/script_executor.cc » ('j') | no next file with comments »