chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.h ('k') | chrome/browser/extensions/extension_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index 26e86ad4196a42e84ef459303285b702c3d58751..392d7492495e25f64920a83d8de21b292e5d4065 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -646,10 +646,10 @@ void WebNavigationTabObserver::FrameDetached(

navigation_state_.FrameDetached(frame_id);

}

-void WebNavigationTabObserver::WebContentsDestroyed(content::WebContents* tab) {

- g_tab_observer.Get().erase(tab);

+void WebNavigationTabObserver::WebContentsDestroyed() {

+ g_tab_observer.Get().erase(web_contents());

registrar_.RemoveAll();

- SendErrorEvents(tab, NULL, FrameNavigationState::FrameID());

+ SendErrorEvents(web_contents(), NULL, FrameNavigationState::FrameID());

}

void WebNavigationTabObserver::SendErrorEvents(