Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2571483003: Stack sampling profiler: update to 10% full disable experiment (Closed)

Created:
4 years ago by Mike Wittman
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stack sampling profiler: update to 10% full disable experiment Stability and performance numbers from the current 50% GPU process enable rate look good. Move on to the third experiment configuration in the associated bug, to test performance impact of enabling the profiler for both GPU and browser processes vs. enabling for neither process. This CL deviates from the roll out percentages in the bug by performing the experiment on 10% of launches rather than 50%. The experiment will be enabled over the holiday period, so the lower percentage will provide enough data while minimizing data volume differences for the browser process. BUG=650869 Committed: https://crrev.com/d3dd30380494ceec5e7d5737cb5387ea75f431b9 Cr-Commit-Position: refs/heads/master@{#437936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/common/stack_sampling_configuration.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mike Wittman
Hi Nico, please take a look.
4 years ago (2016-12-12 19:26:49 UTC) #2
Nico
rs-lgtm
4 years ago (2016-12-12 20:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571483003/1
4 years ago (2016-12-12 20:16:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 22:41:50 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 22:45:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3dd30380494ceec5e7d5737cb5387ea75f431b9
Cr-Commit-Position: refs/heads/master@{#437936}

Powered by Google App Engine
This is Rietveld 408576698