[ios] Updates ios DEPS files.

[ios] Updates ios DEPS files.

BUG=665969
Committed: https://crrev.com/87a42102dad3fa7641eae3fa03646aec6b780ff3
Cr-Commit-Position: refs/heads/master@{#438880}

[rohitrao (ping after 24h), 2016-12-14 21:32:49]

rohitrao@chromium.org changed reviewers:
+ mark@chromium.org, rogerta@chromium.org, sdefresne@chromium.org

[rohitrao (ping after 24h), 2016-12-14 21:32:50]

Pre-adding more DEPS rules for files that will come imminently.

mark@ for "+breakpad/src/client/ios" in ios/chrome/test/DEPS

rogerta@ for "+google_apis" in ios/chrome/test/DEPS

sdefresne@ for various components/ and ios/ additions in all files

[Mark Mentovai, 2016-12-14 21:40:51]

OK, LGTM

[rohitrao (ping after 24h), 2016-12-14 21:41:00]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 21:41:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-12-14 22:07:00]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:17:30]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-12-15 01:59:33]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 01:59:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:04:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rohitrao (ping after 24h), 2016-12-15 02:47:27]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 02:47:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:56:57]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-12-15 11:34:58]

lgtm

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/app/DEPS
File ios/chrome/app/DEPS (right):

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/app/DEPS#new...
ios/chrome/app/DEPS:23: "+ios/chrome/grit",
Maybe create a "# Strings and resource." category like in the other DEPS files
(with components/strings, ios/chrome/grit, ...).

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/today_extens...
File ios/chrome/today_extension/DEPS (right):

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/today_extens...
ios/chrome/today_extension/DEPS:11: "+ios/today_extension/grit",  # For
generated headers
We should generate them in ios/chrome/today_extension/grit. Can you file a bug?
I'll change this post-upstreaming.

[rohitrao (ping after 24h), 2016-12-15 11:42:40]

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/app/DEPS
File ios/chrome/app/DEPS (right):

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/app/DEPS#new...
ios/chrome/app/DEPS:23: "+ios/chrome/grit",
On 2016/12/15 11:34:58, sdefresne wrote:
> Maybe create a "# Strings and resource." category like in the other DEPS files
> (with components/strings, ios/chrome/grit, ...).

Done.

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/today_extens...
File ios/chrome/today_extension/DEPS (right):

https://codereview.chromium.org/2571383002/diff/80001/ios/chrome/today_extens...
ios/chrome/today_extension/DEPS:11: "+ios/today_extension/grit",  # For
generated headers
On 2016/12/15 11:34:58, sdefresne wrote:
> We should generate them in ios/chrome/today_extension/grit. Can you file a
bug?
> I'll change this post-upstreaming.

Acknowledged.

[Roger Tawa OOO till Jul 10th, 2016-12-15 17:54:39]

lgtm

[rohitrao (ping after 24h), 2016-12-15 18:06:24]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-12-15 18:06:25]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2571383002/#ps100001
(title: "Review.")

[commit-bot: I haz the power, 2016-12-15 18:06:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 18:42:18]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481825184586190,
"parent_rev": "91c748335e16aac120484321a3cb5f64186c8f62", "commit_rev":
"0271c03a4bc2889d9056eca8ed3eb2126e845cbe"}

[commit-bot: I haz the power, 2016-12-15 18:42:44]

Description was changed from

==========
[ios] Updates ios DEPS files.

BUG=665969
==========

to

==========
[ios] Updates ios DEPS files.

BUG=665969

Review-Url: https://codereview.chromium.org/2571383002
==========

[commit-bot: I haz the power, 2016-12-15 18:42:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-15 18:44:30]

Description was changed from

==========
[ios] Updates ios DEPS files.

BUG=665969

Review-Url: https://codereview.chromium.org/2571383002
==========

to

==========
[ios] Updates ios DEPS files.

BUG=665969

Committed: https://crrev.com/87a42102dad3fa7641eae3fa03646aec6b780ff3
Cr-Commit-Position: refs/heads/master@{#438880}
==========

[commit-bot: I haz the power, 2016-12-15 18:44:31]

Patchset 6 (id:??) landed as
https://crrev.com/87a42102dad3fa7641eae3fa03646aec6b780ff3
Cr-Commit-Position: refs/heads/master@{#438880}