Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 25713009: Revert 158496 "Update the first letter when the first line is ch..." (Closed)

Created:
7 years, 2 months ago by inferno
Modified:
7 years, 2 months ago
Reviewers:
joone
CC:
blink-reviews
Visibility:
Public.

Description

Revert 158496 "Update the first letter when the first line is ch..." Introduced bad cast regression on ClusterFuzz. > Update the first letter when the first line is changed by adding a new text at its start. > > Currently, CSS first-letter property does not work properly when the first letter is changed > by DOM scripting. This patch allows us to update the first letter and remaining text when the > first letter is changed. > > BUG=92797 > TEST=fast/css/first-letter-block-change.html > > Review URL: https://chromiumcodereview.appspot.com/14113040 TBR=joone.hur@intel.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158774

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
D trunk/LayoutTests/fast/css/first-letter-block-change.html View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/LayoutTests/fast/css/first-letter-block-change-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/Source/core/rendering/RenderBlock.cpp View 3 chunks +4 lines, -18 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
inferno
7 years, 2 months ago (2013-10-03 05:15:16 UTC) #1
inferno
Committed patchset #1 manually as r158774.
7 years, 2 months ago (2013-10-03 05:15:35 UTC) #2
joone
https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/RenderBlock.cpp File trunk/Source/core/rendering/RenderBlock.cpp (left): https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/RenderBlock.cpp#oldcode5856 trunk/Source/core/rendering/RenderBlock.cpp:5856: if (RenderObject* oldRemainingText = toRenderBoxModelObject(currChild->parent())->firstLetterRemainingText()) What do you think ...
7 years, 2 months ago (2013-10-03 18:25:32 UTC) #3
inferno
On 2013/10/03 18:25:32, joone wrote: > https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/RenderBlock.cpp > File trunk/Source/core/rendering/RenderBlock.cpp (left): > > https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/RenderBlock.cpp#oldcode5856 > ...
7 years, 2 months ago (2013-10-03 18:33:51 UTC) #4
joone
7 years, 2 months ago (2013-10-03 18:49:09 UTC) #5
Message was sent while issue was closed.
Do you know how to upload the reverted patch again after fixing it? 
I got an error as follows:

$ git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
ERROR: Your diff contains 1 commits already in refs/remotes/origin/master.
Run "git log --oneline a87cffee00122bf5eda30d4f086d060f12598866..HEAD" to get a
list of commits in the diff.  If you are using a custom git flow, you can
override the reference used for this check with "git config gitcl.remotebranch
<git-ref>".

Git sanity check failure

Powered by Google App Engine
This is Rietveld 408576698