Revert 158496 "Update the first letter when the first line is ch..."

Revert 158496 "Update the first letter when the first line is ch..."

Introduced bad cast regression on ClusterFuzz.

> Update the first letter when the first line is changed by adding a new text at its start.
> 
> Currently, CSS first-letter property does not work properly when the first letter is changed 
> by DOM scripting. This patch allows us to update the first letter and remaining text when the 
> first letter is changed.
> 
> BUG=92797
> TEST=fast/css/first-letter-block-change.html
> 
> Review URL: https://chromiumcodereview.appspot.com/14113040

TBR=joone.hur@intel.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158774

[inferno, 2013-10-03 05:15:35]

Committed patchset #1 manually as r158774.

[joone, 2013-10-03 18:25:32]

https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/R...
File trunk/Source/core/rendering/RenderBlock.cpp (left):

https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/R...
trunk/Source/core/rendering/RenderBlock.cpp:5856: if (RenderObject*
oldRemainingText =
toRenderBoxModelObject(currChild->parent())->firstLetterRemainingText())

What do you think about changing the code as follows?

RenderObject* oldRemainingText =
toRenderBoxModelObject(currChild->parent())->firstLetterRemainingText();
if (oldRemainingText && oldRemainingText->isText())

[inferno, 2013-10-03 18:33:51]

On 2013/10/03 18:25:32, joone wrote:
>
https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/R...
> File trunk/Source/core/rendering/RenderBlock.cpp (left):
> 
>
https://codereview.chromium.org/25713009/diff/1/trunk/Source/core/rendering/R...
> trunk/Source/core/rendering/RenderBlock.cpp:5856: if (RenderObject*
> oldRemainingText =
> toRenderBoxModelObject(currChild->parent())->firstLetterRemainingText())
> 
> What do you think about changing the code as follows?
> 
> RenderObject* oldRemainingText =
> toRenderBoxModelObject(currChild->parent())->firstLetterRemainingText();
> if (oldRemainingText && oldRemainingText->isText())
you shouldn't need the toRenderBoxModelObject cast. rest looks ok. probably get
it reviewed in the original code review, so the the old reviewer (who has better
context) can look at it.

[joone, 2013-10-03 18:49:09]

Do you know how to upload the reverted patch again after fixing it? 
I got an error as follows:

$ git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
ERROR: Your diff contains 1 commits already in refs/remotes/origin/master.
Run "git log --oneline a87cffee00122bf5eda30d4f086d060f12598866..HEAD" to get a
list of commits in the diff.  If you are using a custom git flow, you can
override the reference used for this check with "git config gitcl.remotebranch
<git-ref>".

Git sanity check failure