Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2571283002: Remove StyleDifference::needsPaintPropertyUpdate() (Closed)
Patch Set: Fix layout test failures Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 759b8287c0db8ba5aa3c105fed93b33ba52eaac9..4bb1a9269d1804bc20db1ce51fa2ea7f888a0d57 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1727,15 +1727,18 @@ void LayoutObject::setStyle(PassRefPtr<ComputedStyle> style) {
// Text nodes share style with their parents but the paint properties don't
// apply to them, hence the !isText() check.
- if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() &&
- diff.needsPaintPropertyUpdate() && !isText()) {
+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && !isText() &&
+ (diff.transformChanged() || diff.opacityChanged() ||
+ diff.zIndexChanged() || diff.filterChanged() ||
+ diff.backdropFilterChanged() || diff.cssClipChanged())) {
setNeedsPaintPropertyUpdate();
// We don't need to invalidate paint of objects on SPv2 when only paint
// property or paint order change. Mark the painting layer needing repaint
// for changed paint property or paint order. Raster invalidation will be
// issued if needed during paint.
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
+ !shouldDoFullPaintInvalidation())
ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698