cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets updated). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2571263002
Cr-Commit-Position: refs/heads/master@{#441747}
Committed: https://chromium.googlesource.com/chromium/src/+/8cd27b3cd1d1fe047bcf2c169106ccac7261d4ed

[ajuma, 2016-12-14 18:32:12]

Description was changed from

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

BUG=670074
==========

to

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-01-05 18:26:20]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 18:26:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-01-05 19:12:14]

Description was changed from

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets update). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2017-01-05 19:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:31:17]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-01-05 19:38:06]

Description was changed from

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets update). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets update). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-01-05 19:38:06]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org

[ajuma, 2017-01-05 19:39:19]

PS #1 is the original CL that got reverted, PS #2 has the new changes.

[ajuma, 2017-01-05 20:13:16]

Description was changed from

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets update). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets updated). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-01-05 20:44:33]

lgtm

[ajuma, 2017-01-05 20:56:48]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:57:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:01:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483649808104500,
"parent_rev": "79c766c81131835cc15ca44234a12b7faab715b6", "commit_rev":
"8cd27b3cd1d1fe047bcf2c169106ccac7261d4ed"}

[commit-bot: I haz the power, 2017-01-05 21:02:22]

Description was changed from

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets updated). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex

This relands http://crrev.com/2540333002 with a fix for the crashes
that caused that CL to get reverted.

The previous CL set the effect tree index on surfaces during the surface
update step (when EffectNode::render_surface gets updated). This is not
sufficient, however, since the surface update step will be skipped when
we can't draw, even though property trees can still change and surfaces
can still get destroyed (because of their owning layer getting destroyed).
This CL also updates the effect tree index on surfaces when new property
trees are set (that is, at commit time and at activation time).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2571263002
Cr-Commit-Position: refs/heads/master@{#441747}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cd27b3cd1d1fe047bcf2c169106...
==========

[commit-bot: I haz the power, 2017-01-05 21:02:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8cd27b3cd1d1fe047bcf2c169106...