Move sandbox manifest unittests from chrome/ to extensions/

Move sandbox manifest unittests from chrome/ to extensions/

BUG=None

Committed: https://crrev.com/af6b0e1e087d0cc068d20301a7ee28c8c6374ffd
Cr-Commit-Position: refs/heads/master@{#438632}

[lazyboy, 2016-12-14 02:35:56]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:36:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2016-12-14 02:43:27]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:43:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2016-12-14 02:51:21]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[lazyboy, 2016-12-14 02:51:21]

Came across this test today and it seems that this test doesn't require chrome/,
so moved it to extensions/

[commit-bot: I haz the power, 2016-12-14 05:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 05:09:07]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-14 15:59:54]

lgtm with optional nits/suggestions (none required).

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/BUILD.gn
File extensions/common/BUILD.gn (right):

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/BUILD...
extensions/common/BUILD.gn:330: "manifests_sandboxed_unittest.cc",
Should this go in manifest_handlers/?  (And maybe be renamed to
csp_info_unittest?)

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/manif...
File extensions/common/manifests_sandboxed_unittest.cc (right):

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/manif...
extensions/common/manifests_sandboxed_unittest.cc:13: class
SandboxedPagesManifestTest : public ManifestTest {};
nit: since you're here, maybe
using SandboxedPagesManifestTest (or CSPInfoUnitTets) = ManifestTest;

[lazyboy, 2016-12-14 19:20:44]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[lazyboy, 2016-12-14 19:20:52]

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/BUILD.gn
File extensions/common/BUILD.gn (right):

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/BUILD...
extensions/common/BUILD.gn:330: "manifests_sandboxed_unittest.cc",
On 2016/12/14 15:59:54, Devlin wrote:
> Should this go in manifest_handlers/?  (And maybe be renamed to
> csp_info_unittest?)

Done.

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/manif...
File extensions/common/manifests_sandboxed_unittest.cc (right):

https://codereview.chromium.org/2571123002/diff/40001/extensions/common/manif...
extensions/common/manifests_sandboxed_unittest.cc:13: class
SandboxedPagesManifestTest : public ManifestTest {};
On 2016/12/14 15:59:54, Devlin wrote:
> nit: since you're here, maybe
> using SandboxedPagesManifestTest (or CSPInfoUnitTets) = ManifestTest;

Done.

[commit-bot: I haz the power, 2016-12-14 19:21:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:41:05]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-12-14 21:24:03]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-12-14 21:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2571123002/#ps60001
(title: "rename file")

[commit-bot: I haz the power, 2016-12-14 21:25:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:30:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481750643696400,
"parent_rev": "d3c8d3e11aae0d688c22a808a189a4dbe289b3b8", "commit_rev":
"093fe32c0aa447e95f9dc7a3b61b64e37c254f8b"}

[commit-bot: I haz the power, 2016-12-14 21:31:22]

Description was changed from

==========
Move sandbox manifest unittests from chrome/ to extensions/

BUG=None
==========

to

==========
Move sandbox manifest unittests from chrome/ to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2571123002
==========

[commit-bot: I haz the power, 2016-12-14 21:31:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 21:34:23]

Description was changed from

==========
Move sandbox manifest unittests from chrome/ to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2571123002
==========

to

==========
Move sandbox manifest unittests from chrome/ to extensions/

BUG=None

Committed: https://crrev.com/af6b0e1e087d0cc068d20301a7ee28c8c6374ffd
Cr-Commit-Position: refs/heads/master@{#438632}
==========

[commit-bot: I haz the power, 2016-12-14 21:34:23]

Patchset 4 (id:??) landed as
https://crrev.com/af6b0e1e087d0cc068d20301a7ee28c8c6374ffd
Cr-Commit-Position: refs/heads/master@{#438632}