Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2571093002: MediaRecoder: only throw exception from requestData() if state is inactive (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
haraken, emircan
CC:
chromium-reviews, blink-reviews, emircan+watch+mediarecorder_chromium.org, mcasas+watch+mediarecorder_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecoder: only throw exception from requestData() if state is inactive Simple change to update to the Spec and FF implementation. LayoutTest updated (note that we're still checking that requestData() throws when the state==inactive). BUG=673965 Committed: https://crrev.com/29c40203a88f3e540ca1985d12dcd4de09a07317 Cr-Commit-Position: refs/heads/master@{#438407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-events-and-exceptions.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
mcasas
emircan@ PTAL (tiny change) haraken@ RS plz
4 years ago (2016-12-14 00:57:02 UTC) #2
haraken
LGTM
4 years ago (2016-12-14 01:33:55 UTC) #5
emircan
lgtm
4 years ago (2016-12-14 01:51:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571093002/1
4 years ago (2016-12-14 02:10:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 02:59:56 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 03:01:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29c40203a88f3e540ca1985d12dcd4de09a07317
Cr-Commit-Position: refs/heads/master@{#438407}

Powered by Google App Engine
This is Rietveld 408576698