Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Issue 2571043004: Fix crash in WizardController for Active Directory devices (Closed)

Created:
4 years ago by Roman Sorokin (ftl)
Modified:
4 years ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in WizardController for Active Directory devices IsRemoraRequisition call. BUG=656992 TEST=manual Committed: https://crrev.com/302e3ec3e15d8cc8ddfa6bc481b55289d931c181 Cr-Commit-Position: refs/heads/master@{#438820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Roman Sorokin (ftl)
Alex, PTAL
4 years ago (2016-12-14 16:56:57 UTC) #4
Alexander Alekseev
lgtm
4 years ago (2016-12-15 13:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571043004/1
4 years ago (2016-12-15 13:38:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 13:43:14 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 13:45:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/302e3ec3e15d8cc8ddfa6bc481b55289d931c181
Cr-Commit-Position: refs/heads/master@{#438820}

Powered by Google App Engine
This is Rietveld 408576698