third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h - Issue 2571043002: Set a direct compositing reason for 3D transform & will-change property tree nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

Issue 2571043002: Set a direct compositing reason for 3D transform & will-change property tree nodes (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

index 6121857c7c370eb8207be7f4bdb9d381a28174af..6b4ab0666e6f8f7f6de615752c506735f62bbbcf 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

@@ -31,14 +31,13 @@ class CompositingReasonFinder {

bool hasOverflowScrollTrigger() const;

bool requiresCompositingForScrollableFrame() const;

- bool requiresCompositingForAnimation(const ComputedStyle&) const;

+ static bool requiresCompositingForAnimation(const ComputedStyle&);

+ static bool requiresCompositingForTransform(const LayoutObject&);

private:

bool isMainFrame() const;

CompositingReasons nonStyleDeterminedDirectReasons(const PaintLayer*) const;

- bool requiresCompositingForTransform(LayoutObject*) const;

bool requiresCompositingForScrollDependentPosition(const PaintLayer*) const;

LayoutView& m_layoutView;