Set a direct compositing reason for 3D transform & will-change property tree nodes

Set a direct compositing reason for 3D transform paint property tree nodes.

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/78f6bee5b544282274f8b962a7cca4bf98f2c621
Cr-Commit-Position: refs/heads/master@{#438771}

[chrishtr, 2016-12-13 22:34:10]

Description was changed from

==========
none


none


none


none

BUG=
==========

to

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-13 23:33:42]

Description was changed from

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-13 23:35:34]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2016-12-13 23:35:35]

https://codereview.chromium.org/2571043002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2571043002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:338:
"<style> body { margin: 0 } </style>"
I inlined this for imrpoved clarity and to be like most of the tests
in this file. If you agree, can change the rest o the loadTestData()
instances in another patch.

[chrishtr, 2016-12-14 17:50:44]

Description was changed from

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-14 18:15:36]

Updated to force a transform node if will-change: transform is present.

[pdr., 2016-12-14 21:15:56]

This looks great. Do we need to add additional invalidation to handle changes?
In other words, can you add a test where we add will-change transform and ensure
the transform node is created, and a second test where we remove will-change
transform and ensure the transform node is removed?

[chrishtr, 2016-12-14 22:36:12]

On 2016/12/14 at 21:15:56, pdr wrote:
> This looks great. Do we need to add additional invalidation to handle changes?
In other words, can you add a test where we add will-change transform and ensure
the transform node is created, and a second test where we remove will-change
transform and ensure the transform node is removed?

Done.

[chrishtr, 2016-12-14 22:36:16]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-12-14 23:09:24]

On 2016/12/14 at 22:36:12, chrishtr wrote:
> On 2016/12/14 at 21:15:56, pdr wrote:
> > This looks great. Do we need to add additional invalidation to handle
changes? In other words, can you add a test where we add will-change transform
and ensure the transform node is created, and a second test where we remove
will-change transform and ensure the transform node is removed?
> 
> Done.

We discussed this and are unsure how it passes because will-change: transform
changes do not currently call setNeedsPaintPropertyUpdate. Similar code for this
is in ComputedStyle::diffNeedsPaintPropertyUpdate, but doesn't include
will-change. We think these tests are passing because layer existence changes.

[pdr., 2016-12-14 23:39:40]

On 2016/12/14 at 23:09:24, pdr. wrote:
> On 2016/12/14 at 22:36:12, chrishtr wrote:
> > On 2016/12/14 at 21:15:56, pdr wrote:
> > > This looks great. Do we need to add additional invalidation to handle
changes? In other words, can you add a test where we add will-change transform
and ensure the transform node is created, and a second test where we remove
will-change transform and ensure the transform node is removed?
> > 
> > Done.
> 
> We discussed this and are unsure how it passes because will-change: transform
changes do not currently call setNeedsPaintPropertyUpdate. Similar code for this
is in ComputedStyle::diffNeedsPaintPropertyUpdate, but doesn't include
will-change. We think these tests are passing because layer existence changes.

We found the call! All is well in this code now.

LGTM

[chrishtr, 2016-12-14 23:42:54]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-12-14 23:42:56]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:43:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-12-15 02:10:25]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-15 02:10:25]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2571043002/#ps100001
(title: "none")

[commit-bot: I haz the power, 2016-12-15 02:10:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:17:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-12-15 02:33:08]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:33:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:38:17]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-12-15 05:19:45]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-12-15 05:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:02:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481779185782710,
"parent_rev": "d8fb0cc583c3d3e82e00dc9c08ecde041c115e3c", "commit_rev":
"f242e4bc5f2cea60f8b12a1eeed3828432765397"}

[commit-bot: I haz the power, 2016-12-15 07:02:51]

Description was changed from

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2571043002
==========

[commit-bot: I haz the power, 2016-12-15 07:02:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-15 07:04:59]

Description was changed from

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2571043002
==========

to

==========
Set a direct compositing reason for 3D transform paint property tree nodes.

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/78f6bee5b544282274f8b962a7cca4bf98f2c621
Cr-Commit-Position: refs/heads/master@{#438771}
==========

[commit-bot: I haz the power, 2016-12-15 07:05:00]

Patchset 6 (id:??) landed as
https://crrev.com/78f6bee5b544282274f8b962a7cca4bf98f2c621
Cr-Commit-Position: refs/heads/master@{#438771}