Set a direct compositing reason for 3D transform & will-change property tree nodes

third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/compositing/CompositingReasonFinder.h"
 
 #include "core/CSSPropertyNames.h"
 #include "core/dom/Document.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
@@ skipping 56 matching lines @@
 CompositingReasons
 CompositingReasonFinder::potentialCompositingReasonsFromStyle(
     LayoutObject* layoutObject) const {
   if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
     return CompositingReasonNone;
 
   CompositingReasons reasons = CompositingReasonNone;
 
   const ComputedStyle& style = layoutObject->styleRef();
 
-  if (requiresCompositingForTransform(layoutObject))
+  if (requiresCompositingForTransform(*layoutObject))
     reasons |= CompositingReason3DTransform;
 
   if (style.backfaceVisibility() == BackfaceVisibilityHidden)
     reasons |= CompositingReasonBackfaceVisibilityHidden;
 
   if (requiresCompositingForAnimation(style))
     reasons |= CompositingReasonActiveAnimation;
 
   if (style.hasWillChangeCompositingHint() &&
       !style.subtreeWillChangeContents())
@@ skipping 37 matching lines @@
     reasons |= CompositingReasonBlendingWithCompositedDescendants;
 
   if (layoutObject->hasReflection())
     reasons |= CompositingReasonReflectionWithCompositedDescendants;
 
   DCHECK(!(reasons & ~CompositingReasonComboAllStyleDeterminedReasons));
   return reasons;
 }
 
 bool CompositingReasonFinder::requiresCompositingForTransform(
-    LayoutObject* layoutObject) const {
+    const LayoutObject& layoutObject) {
   // Note that we ask the layoutObject if it has a transform, because the style
   // may have transforms, but the layoutObject may be an inline that doesn't
   // support them.
-  return layoutObject->hasTransformRelatedProperty() &&
-         layoutObject->style()->has3DTransform();
+  return layoutObject.hasTransformRelatedProperty() &&
+         layoutObject.styleRef().has3DTransform();
 }
 
 CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(
     const PaintLayer* layer) const {
   CompositingReasons directReasons = CompositingReasonNone;
   LayoutObject* layoutObject = layer->layoutObject();
 
   if (m_compositingTriggers & OverflowScrollTrigger && layer->clipParent())
     directReasons |= CompositingReasonOutOfFlowClipping;
 
@@ skipping 13 matching lines @@
   if (requiresCompositingForScrollDependentPosition(layer))
     directReasons |= CompositingReasonScrollDependentPosition;
 
   directReasons |= layoutObject->additionalCompositingReasons();
 
   DCHECK(!(directReasons & CompositingReasonComboAllStyleDeterminedReasons));
   return directReasons;
 }
 
 bool CompositingReasonFinder::requiresCompositingForAnimation(
-    const ComputedStyle& style) const {
+    const ComputedStyle& style) {
   if (style.subtreeWillChangeContents())
     return style.isRunningAnimationOnCompositor();
 
   return style.shouldCompositeForCurrentAnimations();
 }
 
 bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(
     const PaintLayer* layer) const {
   if (layer->layoutObject()->style()->position() != FixedPosition &&
       layer->layoutObject()->style()->position() != StickyPosition)
     return false;
 
   if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) &&
       (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() ||
        !layer->backgroundIsKnownToBeOpaqueInRect(
            LayoutRect(layer->boundingBoxForCompositing())) ||
        layer->compositesWithTransform() || layer->compositesWithOpacity())) {
     return false;
   }
   // Don't promote fixed position elements that are descendants of a non-view
   // container, e.g. transformed elements.  They will stay fixed wrt the
   // container rather than the enclosing frame.
   if (layer->sticksToViewport())
     return m_layoutView.frameView()->isScrollable();
   return layer->layoutObject()->style()->position() == StickyPosition &&
          layer->ancestorOverflowLayer()->scrollsOverflow();
 }
 
 }  // namespace blink