win/clang/x86: Use clang for 64-bit part of cloudprint.

win/clang/x86: Use clang for 64-bit part of cloudprint.

BUG=672229
Committed: https://crrev.com/b7e2bae9556c53e66d478774f70dc75c7cb9e687
Cr-Commit-Position: refs/heads/master@{#438550}

[Nico, 2016-12-14 15:29:55]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 15:30:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-12-14 15:30:11]

thakis@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[Nico, 2016-12-14 15:30:11]

See https://cs.chromium.org/search/?q=win:x64&sq=package:chromium&type=cs for
other examples.

[pastarmovj, 2016-12-14 15:40:57]

thanks for the fix! lgtm

One additional question - do you know how can one add a cross-compile option to
the build file so that on a 64bit or 32bit build both artifacts are produced
next to each other. It used to be that the portmon was built in both 32 and 64
bit flavors with one being called gcp_portmon.dll and the other
gcp_portmon64.dll. I had to strip the non-functional way it was done in the
original CL away to get the 64bit version compiling which was a priority. But it
will be good to start providing both 32 and 64bit versions of the dll.

[Nico, 2016-12-14 15:44:23]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-12-14 15:44:27]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-12-14 15:53:40]

On 2016/12/14 15:40:57, pastarmovj wrote:
> thanks for the fix! lgtm
> 
> One additional question - do you know how can one add a cross-compile option
to
> the build file so that on a 64bit or 32bit build both artifacts are produced
> next to each other. It used to be that the portmon was built in both 32 and 64
> bit flavors with one being called gcp_portmon.dll and the other
> gcp_portmon64.dll. I had to strip the non-functional way it was done in the
> original CL away to get the 64bit version compiling which was a priority. But
it
> will be good to start providing both 32 and 64bit versions of the dll.

You have to add an explicit copy step to copy it over. Example:
https://cs.chromium.org/chromium/src/courgette/BUILD.gn?rcl=0&l=135

[commit-bot: I haz the power, 2016-12-14 16:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:05:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-12-14 16:11:15]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:32:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:32:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-12-14 16:33:28]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:33:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:44:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481733208415180, "parent_rev":
"486faec093f2f5424cf89c4f2e5a54fa8204da7e", "commit_rev":
"de6000d6258a4f2b0c6110a32142e07e7cebbc81"}

[commit-bot: I haz the power, 2016-12-14 18:44:36]

Description was changed from

==========
win/clang/x86: Use clang for 64-bit part of cloudprint.

BUG=672229
==========

to

==========
win/clang/x86: Use clang for 64-bit part of cloudprint.

BUG=672229

Review-Url: https://codereview.chromium.org/2571023003
==========

[commit-bot: I haz the power, 2016-12-14 18:44:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 18:46:06]

Description was changed from

==========
win/clang/x86: Use clang for 64-bit part of cloudprint.

BUG=672229

Review-Url: https://codereview.chromium.org/2571023003
==========

to

==========
win/clang/x86: Use clang for 64-bit part of cloudprint.

BUG=672229

Committed: https://crrev.com/b7e2bae9556c53e66d478774f70dc75c7cb9e687
Cr-Commit-Position: refs/heads/master@{#438550}
==========

[commit-bot: I haz the power, 2016-12-14 18:46:07]

Patchset 1 (id:??) landed as
https://crrev.com/b7e2bae9556c53e66d478774f70dc75c7cb9e687
Cr-Commit-Position: refs/heads/master@{#438550}