Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2571023002:
Add check to InlineFlowBox::computeLogicalBoxHeights (Closed)
|
Created:
4 years ago by eae Modified:
4 years ago Reviewers:
szager1 CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd check to InlineFlowBox::computeLogicalBoxHeights
Add a null check for rootBox to InlineFlowBox::computeLogicalBoxHeights.
BUG=664851
R=szager@chromium.org
Committed: https://crrev.com/16f66a38edc9d1b63276df3fdfc673138e18a917
Cr-Commit-Position: refs/heads/master@{#438336}
Patch Set 1 #
Messages
Total messages: 25 (9 generated)
The CQ bit was checked by eae@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== check ========== to ========== Add check to InlineFlowBox::computeLogicalBoxHeights Add a null check for rootBox to InlineFlowBox::computeLogicalBoxHeights. BUG=664851 R=szager@chromium.org ==========
eae@chromium.org changed reviewers: + szager@chromium.org
Speculative fix for bug 664851.
lgtm
The CQ bit was unchecked by eae@chromium.org
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481668564377900, "parent_rev":
"39faed6285503d02ddf4a17cf6d3729bcf30f726", "commit_rev":
"f8c88474306dcf7a5e83a87ec142d7d8aaf00af7"}
Message was sent while issue was closed.
Description was changed from ========== Add check to InlineFlowBox::computeLogicalBoxHeights Add a null check for rootBox to InlineFlowBox::computeLogicalBoxHeights. BUG=664851 R=szager@chromium.org ========== to ========== Add check to InlineFlowBox::computeLogicalBoxHeights Add a null check for rootBox to InlineFlowBox::computeLogicalBoxHeights. BUG=664851 R=szager@chromium.org Review-Url: https://codereview.chromium.org/2571023002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add check to InlineFlowBox::computeLogicalBoxHeights Add a null check for rootBox to InlineFlowBox::computeLogicalBoxHeights. BUG=664851 R=szager@chromium.org Review-Url: https://codereview.chromium.org/2571023002 ========== to ========== Add check to InlineFlowBox::computeLogicalBoxHeights Add a null check for rootBox to InlineFlowBox::computeLogicalBoxHeights. BUG=664851 R=szager@chromium.org Committed: https://crrev.com/16f66a38edc9d1b63276df3fdfc673138e18a917 Cr-Commit-Position: refs/heads/master@{#438336} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/16f66a38edc9d1b63276df3fdfc673138e18a917 Cr-Commit-Position: refs/heads/master@{#438336} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
