Add protocol and port to HTTPResponse.

Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956
Committed: https://crrev.com/db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f
Cr-Commit-Position: refs/heads/master@{#438324}

[Robert Ogden, 2016-12-13 20:48:26]

Description was changed from

==========
Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956
==========

to

==========
Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956
==========

[Robert Ogden, 2016-12-13 20:48:26]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[RyanSturm, 2016-12-13 21:30:11]

https://codereview.chromium.org/2571003002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2571003002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:45: parser.add_argument('-b', '--buffer',
help='The standard output and standard '
These are awesome. Can you make the buffer one default, and change the flag to
disable it instead?

--disable_buffer maybe

https://codereview.chromium.org/2571003002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:310: This function should be called
exactly once after every page load.
nit: s/exactly once/at most once/

nit, maybe: You should enforce that it is only called at most once per page load
or remove the comment.
Does this break if you call it more than once per page load or is just 
ineffecient?

[Robert Ogden, 2016-12-13 21:51:26]

https://codereview.chromium.org/2571003002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2571003002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:45: parser.add_argument('-b', '--buffer',
help='The standard output and standard '
On 2016/12/13 21:30:11, Ryan Sturm wrote:
> These are awesome. Can you make the buffer one default, and change the flag to
> disable it instead?
> 
> --disable_buffer maybe
> 

Done.

https://codereview.chromium.org/2571003002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:310: This function should be called
exactly once after every page load.
On 2016/12/13 21:30:11, Ryan Sturm wrote:
> nit: s/exactly once/at most once/
> 
> nit, maybe: You should enforce that it is only called at most once per page
load
> or remove the comment.
> Does this break if you call it more than once per page load or is just 
> ineffecient?

Clarified

[RyanSturm, 2016-12-13 22:01:47]

lgtm

[Robert Ogden, 2016-12-13 22:02:06]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:03:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:04:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481666526011630,
"parent_rev": "115a69ef1881ccb2efd030359cde7ebab4245e91", "commit_rev":
"4e3511f336add16a6f6a12f211a1a484dc77fc1f"}

[commit-bot: I haz the power, 2016-12-13 23:04:42]

Description was changed from

==========
Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956
==========

to

==========
Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956

Review-Url: https://codereview.chromium.org/2571003002
==========

[commit-bot: I haz the power, 2016-12-13 23:04:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 23:06:51]

Description was changed from

==========
Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956

Review-Url: https://codereview.chromium.org/2571003002
==========

to

==========
Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG=669956

Committed: https://crrev.com/db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f
Cr-Commit-Position: refs/heads/master@{#438324}
==========

[commit-bot: I haz the power, 2016-12-13 23:06:51]

Patchset 3 (id:??) landed as
https://crrev.com/db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f
Cr-Commit-Position: refs/heads/master@{#438324}