Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2570963003: Revert of Rewrite LogDog log viewer app. (Closed)

Created:
4 years ago by dnj
Modified:
4 years ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Revert of Rewrite LogDog log viewer app. (patchset #3 id:60001 of https://codereview.chromium.org/2543323004/ ) Reason for revert: TypeScript is not ready yet. Original issue's description: > Rewrite LogDog log viewer app. > > Rewrite the LogDog log viewer app in TypeScript, and integrate it into > the Gulp viewer. This adds many features, including: > - Actual TypeScript 2.0 versions of the LogDog libraries. > - The ability to perform log tails and manual (on-demand) log loading. > - Much faster log rendering (by default). > - Prefetch initial log chunk so it feels more responsive. > - Better model/view/controller separation. > - Transient HTTP and RPC retries. > - A tighter authentication loop, hopefully better now. > - Better support for mobile apps. > > The current state of things is hybrid JavaScript / Polymer / TypeScript > because too much change in one CL is bad. The minimum bridges were built > between the JavaScript libraries that weren't rewritten and the > TypeScript code that uses them. > > The TypeScript code is smaller, cleaner, and (obivously) stronger typed. > This should lead to its significantly-increased enhancement and > maintainability. > > Polymer integrates TypeScript by including it during vulcanization. This > requires the Gulp build system to include an intermediate "build" > directory step, where the original sources are copied over and the > transpiled JavaScript code is generated. > > BUG=chromium:667990 > TEST=local > - Ran the app locally, seems to work under all expected circumstances. > > Review-Url: https://codereview.chromium.org/2543323004 > Committed: https://github.com/luci/luci-go/commit/2cc68ad46a2c1c332d5d1d3b3b86cd3efd5c6281 TBR=estaab@chromium.org,hinoka@chromium.org,hinoka@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:667990 Review-Url: https://codereview.chromium.org/2570963003 Committed: https://github.com/luci/luci-go/commit/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1279 lines, -3046 lines) Patch
M web/apps/gulp-common.js View 10 chunks +31 lines, -130 lines 0 comments Download
M web/apps/logdog-app/elements/elements.html View 1 chunk +3 lines, -2 lines 0 comments Download
M web/apps/logdog-app/elements/logdog-app/logdog-app.html View 3 chunks +2 lines, -3 lines 0 comments Download
D web/apps/logdog-app/elements/logdog-app/logdog-scripts-main.html View 1 chunk +0 lines, -10 lines 0 comments Download
M web/apps/logdog-app/elements/routing.html View 3 chunks +9 lines, -27 lines 0 comments Download
M web/apps/logdog-app/index.html View 1 chunk +0 lines, -1 line 0 comments Download
D web/apps/logdog-app/scripts-ts/main.ts View 1 chunk +0 lines, -9 lines 0 comments Download
D web/apps/logdog-app/scripts-ts/tsconfig.json View 1 chunk +0 lines, -7 lines 0 comments Download
M web/apps/logdog-view/elements/elements.html View 2 chunks +5 lines, -3 lines 0 comments Download
D web/apps/logdog-view/elements/logdog-view/logdog-scripts-main.html View 1 chunk +0 lines, -10 lines 0 comments Download
M web/apps/logdog-view/elements/logdog-view/logdog-view.html View 5 chunks +21 lines, -39 lines 0 comments Download
M web/apps/logdog-view/gulpfile.js View 1 chunk +2 lines, -0 lines 0 comments Download
A web/apps/logdog-view/inc View 1 chunk +1 line, -0 lines 0 comments Download
M web/apps/logdog-view/index.html View 1 chunk +0 lines, -1 line 0 comments Download
D web/apps/logdog-view/scripts-ts/main.ts View 1 chunk +0 lines, -9 lines 0 comments Download
D web/apps/logdog-view/scripts-ts/tsconfig.json View 1 chunk +0 lines, -7 lines 0 comments Download
M web/bower.json View 1 chunk +1 line, -2 lines 0 comments Download
D web/inc/README.md View 1 chunk +0 lines, -9 lines 0 comments Download
M web/inc/logdog-app-base/logdog-app-base.html View 1 chunk +0 lines, -3 lines 0 comments Download
D web/inc/logdog-stream-view/fetcher.ts View 1 chunk +0 lines, -359 lines 0 comments Download
A web/inc/logdog-stream-view/logdog-stream-fetcher.html View 1 chunk +164 lines, -0 lines 0 comments Download
A web/inc/logdog-stream-view/logdog-stream-query.html View 1 chunk +193 lines, -0 lines 0 comments Download
M web/inc/logdog-stream-view/logdog-stream-view.html View 14 chunks +813 lines, -688 lines 0 comments Download
D web/inc/logdog-stream-view/query.ts View 1 chunk +0 lines, -143 lines 0 comments Download
D web/inc/logdog-stream-view/viewer.ts View 1 chunk +0 lines, -1150 lines 0 comments Download
D web/inc/logdog-stream/logdog.ts View 1 chunk +0 lines, -169 lines 0 comments Download
M web/inc/logdog-stream/logdog-error.html View 1 chunk +2 lines, -17 lines 0 comments Download
A web/inc/luci-sleep-promise/luci-sleep-promise.html View 1 chunk +24 lines, -0 lines 0 comments Download
D web/inc/luci-sleep-promise/promise.ts View 1 chunk +0 lines, -11 lines 0 comments Download
D web/inc/rpc/client.ts View 1 chunk +0 lines, -200 lines 0 comments Download
M web/inc/rpc/rpc-call.html View 2 chunks +3 lines, -4 lines 0 comments Download
M web/inc/rpc/rpc-error.html View 1 chunk +0 lines, -12 lines 0 comments Download
D web/inc/tsconfig.json View 1 chunk +0 lines, -7 lines 0 comments Download
M web/package.json View 4 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dnj
Created Revert of Rewrite LogDog log viewer app.
4 years ago (2016-12-13 23:35:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570963003/1
4 years ago (2016-12-13 23:35:05 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-13 23:42:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/4588c02fe11509e38d8192ee6d18c45bbc2d1ee8

Powered by Google App Engine
This is Rietveld 408576698