Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Issue 2570933002: Fix null dereference in ExtensionsGuestViewManagerDelegate. (Closed)

Created:
4 years ago by jam
Modified:
4 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null dereference in ExtensionsGuestViewManagerDelegate. This is racy, so I could only see it with PlzNavigate sometimes, and only after the test finished and the browser windows were being closed. This deflakes WebViewTests/WebViewTest.Shim_TestNestedCrossOriginSubframes with PlzNavigate. BUG=504347 Committed: https://crrev.com/44fcfe5a1b9ab5e64cf4eabd96621e88fa7a4b60 Cr-Commit-Position: refs/heads/master@{#438266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jam
4 years ago (2016-12-13 19:00:57 UTC) #3
Fady Samuel
lgtm
4 years ago (2016-12-13 19:03:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570933002/1
4 years ago (2016-12-13 19:05:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 19:56:16 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-13 19:59:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44fcfe5a1b9ab5e64cf4eabd96621e88fa7a4b60
Cr-Commit-Position: refs/heads/master@{#438266}

Powered by Google App Engine
This is Rietveld 408576698