Media Galleries: Fix render-process-gone case in GetMetadata call

Media Galleries: Fix render-process-gone case in GetMetadata call

Sometimes the render process goes away (tab closed, crashes, etc.)
before the MediaGalleries GetMetadata call completes.

This CL adds a nullptr check to gracefully handle that case.

BUG=673459
Committed: https://crrev.com/156d2b857294d592ff2e05c528c85cb49f71eaa9
Cr-Commit-Position: refs/heads/master@{#438848}

[tommycli, 2016-12-13 17:51:57]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 17:52:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 19:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:26:22]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-12-13 19:29:04]

tommycli@chromium.org changed reviewers:
+ zelidrag@chromium.org

[tommycli, 2016-12-13 19:29:05]

zelidrag: PTAL, i think this will fix that null crash. Thanks. Tommy

[tommycli, 2016-12-14 18:36:40]

tommycli@chromium.org changed reviewers:
+ hirono@chromium.org

[tommycli, 2016-12-14 18:36:41]

hirono: PTAL if interested

[hirono, 2016-12-15 00:20:14]

lgtm, thank you for fixing this!

[tommycli, 2016-12-15 00:29:44]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-12-15 00:29:51]

On 2016/12/15 00:20:14, hirono wrote:
> lgtm, thank you for fixing this!

thanks!

[commit-bot: I haz the power, 2016-12-15 00:30:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:39:01]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tommycli, 2016-12-15 00:46:52]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:47:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:53:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tommycli, 2016-12-15 01:03:39]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:10:37]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tommycli, 2016-12-15 16:08:47]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-12-15 16:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 16:47:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481818127970480, "parent_rev":
"e1d904f25b25e55ca9973ba1c910d840a5e13485", "commit_rev":
"6ce511d169bde318fb4e80de5d53a3680bffee38"}

[commit-bot: I haz the power, 2016-12-15 16:48:22]

Description was changed from

==========
Media Galleries: Fix render-process-gone case in GetMetadata call

Sometimes the render process goes away (tab closed, crashes, etc.)
before the MediaGalleries GetMetadata call completes.

This CL adds a nullptr check to gracefully handle that case.

BUG=673459
==========

to

==========
Media Galleries: Fix render-process-gone case in GetMetadata call

Sometimes the render process goes away (tab closed, crashes, etc.)
before the MediaGalleries GetMetadata call completes.

This CL adds a nullptr check to gracefully handle that case.

BUG=673459

Review-Url: https://codereview.chromium.org/2570903002
==========

[commit-bot: I haz the power, 2016-12-15 16:48:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-15 16:51:04]

Description was changed from

==========
Media Galleries: Fix render-process-gone case in GetMetadata call

Sometimes the render process goes away (tab closed, crashes, etc.)
before the MediaGalleries GetMetadata call completes.

This CL adds a nullptr check to gracefully handle that case.

BUG=673459

Review-Url: https://codereview.chromium.org/2570903002
==========

to

==========
Media Galleries: Fix render-process-gone case in GetMetadata call

Sometimes the render process goes away (tab closed, crashes, etc.)
before the MediaGalleries GetMetadata call completes.

This CL adds a nullptr check to gracefully handle that case.

BUG=673459

Committed: https://crrev.com/156d2b857294d592ff2e05c528c85cb49f71eaa9
Cr-Commit-Position: refs/heads/master@{#438848}
==========

[commit-bot: I haz the power, 2016-12-15 16:51:05]

Patchset 1 (id:??) landed as
https://crrev.com/156d2b857294d592ff2e05c528c85cb49f71eaa9
Cr-Commit-Position: refs/heads/master@{#438848}