Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2570873003: [CUPS] Fix the width of the printer protocol dropdown menu. (Closed)

Created:
4 years ago by xdai1
Modified:
4 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Fix the width of the printer protocol dropdown menu. BUG=656807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c3f24fcf763f2e749b7077aed2fd169d33df91d2 Cr-Commit-Position: refs/heads/master@{#438639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
4 years ago (2016-12-14 00:49:23 UTC) #3
michaelpg
lgtm
4 years ago (2016-12-14 20:21:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570873003/1
4 years ago (2016-12-14 20:48:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 21:51:36 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 21:56:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3f24fcf763f2e749b7077aed2fd169d33df91d2
Cr-Commit-Position: refs/heads/master@{#438639}

Powered by Google App Engine
This is Rietveld 408576698