Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2570813002: [turbofan] Remove value numbering from late optimization pass. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove value numbering from late optimization pass. Committed: https://crrev.com/e32535af5a5f4776a58ef434ea77d56528ded427 Cr-Commit-Position: refs/heads/master@{#41672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Jarin
Could you take a look, please? (The gameboy regression does not seem to be real, ...
4 years ago (2016-12-13 11:44:25 UTC) #2
Benedikt Meurer
LGTM, Thanks!
4 years ago (2016-12-13 12:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570813002/1
4 years ago (2016-12-13 12:37:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 13:02:58 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e32535af5a5f4776a58ef434ea77d56528ded427 Cr-Commit-Position: refs/heads/master@{#41672}
4 years ago (2016-12-13 13:03:26 UTC) #10
Jarin
4 years ago (2016-12-16 09:53:33 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2579273002/ by jarin@chromium.org.

The reason for reverting is: Tanks Kraken astar benchmark..

Powered by Google App Engine
This is Rietveld 408576698