Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2570783004: [heap] Set class RememberedSet to AllStatic (Closed)

Created:
4 years ago by honggyu.kim
Modified:
4 years ago
Reviewers:
ulan, Yang
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Set class RememberedSet to AllStatic Since class RememberedSet only contains static methods, it'd be better to make it as AllStatic class. BUG= R=ulan@chromium.org, yangguo@chromium.org Committed: https://crrev.com/6106a483de0038b0c1168ad9db74901c648b4e9c Cr-Commit-Position: refs/heads/master@{#41678}

Patch Set 1 #

Patch Set 2 : [heap] Set class RememberedSet to AllStatic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/remembered-set.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
honggyu.kim
4 years ago (2016-12-13 14:54:01 UTC) #1
ulan
LGTM. Please sign the CLA (electronically) https://developers.google.com/open-source/cla/individual and add yourself to src/AUTHORS before committing.
4 years ago (2016-12-13 15:03:27 UTC) #2
ulan
On 2016/12/13 15:03:27, ulan wrote: > LGTM. Please sign the CLA (electronically) > https://developers.google.com/open-source/cla/individual > ...
4 years ago (2016-12-13 15:07:39 UTC) #3
honggyu.kim
On 2016/12/13 15:07:39, ulan wrote: > On 2016/12/13 15:03:27, ulan wrote: > > LGTM. Please ...
4 years ago (2016-12-13 15:09:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570783004/20001
4 years ago (2016-12-13 15:09:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 15:36:25 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-13 15:37:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6106a483de0038b0c1168ad9db74901c648b4e9c
Cr-Commit-Position: refs/heads/master@{#41678}

Powered by Google App Engine
This is Rietveld 408576698