components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h - Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h

Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl (Closed)

Patch Set: Split PopularSitesImpl. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_tiles/popular_sites.h ('K') | « components/ntp_tiles/webui/popular_sites_internals_message_handler.h ('k') | ios/chrome/browser/prefs/browser_prefs.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h

diff --git a/components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h b/components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h

index 45797e24069728cfda8eda8d5e9232bdf4bbb321..4cdcd938306a84988cc607543478dadfbf3cdd98 100644

--- a/components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h

+++ b/components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h

@@ -22,7 +22,7 @@ class SequencedWorkerPool;

namespace ntp_tiles {

-class PopularSites;

+class PopularSitesImpl;

// Implemented by embedders to hook up PopularSitesInternalsMessageHandler.

class PopularSitesInternalsMessageHandlerClient {

@@ -33,8 +33,8 @@ class PopularSitesInternalsMessageHandlerClient {

// Returns the PrefService for the embedder and containing WebUI page.

virtual PrefService* GetPrefs() = 0;

- // Creates a new PopularSites based on the context pf the WebUI page.

- virtual std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() = 0;

+ // Creates a new PopularSitesImpl based on the context pf the WebUI page.

+ virtual std::unique_ptr<ntp_tiles::PopularSitesImpl> MakePopularSites() = 0;

// Registers a callback in Javascript. See content::WebUI and web::WebUIIOS.

virtual void RegisterMessageCallback(