components/ntp_tiles/webui/popular_sites_internals_message_handler.h - Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/webui/popular_sites_internals_message_handler.h

Issue 2570783003: [Popular Sites] Split PopularSites interface and PopularSitesImpl (Closed)

Patch Set: Split PopularSitesImpl. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_tiles/popular_sites.h ('K') | « components/ntp_tiles/popular_sites_unittest.cc ('k') | components/ntp_tiles/webui/popular_sites_internals_message_handler_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_tiles/webui/popular_sites_internals_message_handler.h

diff --git a/components/ntp_tiles/webui/popular_sites_internals_message_handler.h b/components/ntp_tiles/webui/popular_sites_internals_message_handler.h

index 3dbc74522e6301f4751708b2f5e8cb593651fbd0..3583b02c0a184f2e3b9c984d24fa8d1bb58932cc 100644

--- a/components/ntp_tiles/webui/popular_sites_internals_message_handler.h

+++ b/components/ntp_tiles/webui/popular_sites_internals_message_handler.h

@@ -17,7 +17,7 @@ class ListValue;

namespace ntp_tiles {

-class PopularSites;

+class PopularSitesImpl;

class PopularSitesInternalsMessageHandlerClient;

// Implements the WebUI message handler for chrome://popular-sites-internals/

@@ -52,7 +52,7 @@ class PopularSitesInternalsMessageHandler {

// Bridge to embedder's API.

PopularSitesInternalsMessageHandlerClient* web_ui_;

- std::unique_ptr<PopularSites> popular_sites_;

+ std::unique_ptr<PopularSitesImpl> popular_sites_;

base::WeakPtrFactory<PopularSitesInternalsMessageHandler> weak_ptr_factory_;