Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: chrome/browser/resources/settings/device_page/keyboard.html

Issue 2570743002: Keyboard settings: icon buttons for tappable rows (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/device_page/keyboard.html
diff --git a/chrome/browser/resources/settings/device_page/keyboard.html b/chrome/browser/resources/settings/device_page/keyboard.html
index 6b111be75f11b3673725b225b3ab84caaab3401e..cb7b630674f6348b08f6c121854225f8524ed36e 100644
--- a/chrome/browser/resources/settings/device_page/keyboard.html
+++ b/chrome/browser/resources/settings/device_page/keyboard.html
@@ -3,6 +3,7 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
<link rel="import" href="/controls/settings_checkbox.html">
<link rel="import" href="/controls/settings_dropdown_menu.html">
<link rel="import" href="/i18n_setup.html">
@@ -109,10 +110,12 @@
</iron-collapse>
<div id="keyboardOverlay" class="settings-box"
on-tap="onShowKeyboardShortcutsOverlayTap_" actionable>
- $i18n{showKeyboardShortcutsOverlay}
+ <div class="start">$i18n{showKeyboardShortcutsOverlay}</div>
+ <button class="icon-external" is="paper-icon-button-light"></button>
</div>
<div class="settings-box" on-tap="onShowLanguageInputTap_" actionable>
- $i18n{keyboardShowLanguageAndInput}
+ <div class="start">$i18n{keyboardShowLanguageAndInput}</div>
+ <button class="subpage-arrow" is="paper-icon-button-light"></button>
hcarmona 2016/12/13 18:00:47 subpage-arrow seems a bit odd to me because we're
michaelpg 2016/12/13 23:21:44 Storage management does this (CrOS). I also filed
michaelpg 2016/12/17 07:11:15 See dbeam's replies at crbug.com/673925 -- I think
hcarmona 2016/12/19 20:00:38 Sounds good.
</div>
</template>
<script src="keyboard.js"></script>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698