Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: chrome/browser/resources/settings/device_page/keyboard.html

Issue 2570743002: Keyboard settings: icon buttons for tappable rows (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_slider/cr_slider.html "> 1 <link rel="import" href="chrome://resources/cr_elements/cr_slider/cr_slider.html ">
2 <link rel="import" href="chrome://resources/html/cr.html"> 2 <link rel="import" href="chrome://resources/html/cr.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
6 <link rel="import" href="/controls/settings_checkbox.html"> 7 <link rel="import" href="/controls/settings_checkbox.html">
7 <link rel="import" href="/controls/settings_dropdown_menu.html"> 8 <link rel="import" href="/controls/settings_dropdown_menu.html">
8 <link rel="import" href="/i18n_setup.html"> 9 <link rel="import" href="/i18n_setup.html">
9 <link rel="import" href="/route.html"> 10 <link rel="import" href="/route.html">
10 <link rel="import" href="/settings_shared_css.html"> 11 <link rel="import" href="/settings_shared_css.html">
11 12
12 <dom-module id="settings-keyboard"> 13 <dom-module id="settings-keyboard">
13 <template> 14 <template>
14 <style include="settings-shared"></style> 15 <style include="settings-shared"></style>
15 <div class="settings-box first"> 16 <div class="settings-box first">
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 tick-values="[[autoRepeatIntervals_]]" 103 tick-values="[[autoRepeatIntervals_]]"
103 disabled="[[!prefs.settings.language.xkb_auto_repeat_enabled_r2.va lue]]" 104 disabled="[[!prefs.settings.language.xkb_auto_repeat_enabled_r2.va lue]]"
104 aria-labelledby="repeatRateLabel"> 105 aria-labelledby="repeatRateLabel">
105 </cr-slider> 106 </cr-slider>
106 <div>$i18n{keyRepeatRateFast}</div> 107 <div>$i18n{keyRepeatRateFast}</div>
107 </div> 108 </div>
108 </div> 109 </div>
109 </iron-collapse> 110 </iron-collapse>
110 <div id="keyboardOverlay" class="settings-box" 111 <div id="keyboardOverlay" class="settings-box"
111 on-tap="onShowKeyboardShortcutsOverlayTap_" actionable> 112 on-tap="onShowKeyboardShortcutsOverlayTap_" actionable>
112 $i18n{showKeyboardShortcutsOverlay} 113 <div class="start">$i18n{showKeyboardShortcutsOverlay}</div>
114 <button class="icon-external" is="paper-icon-button-light"></button>
113 </div> 115 </div>
114 <div class="settings-box" on-tap="onShowLanguageInputTap_" actionable> 116 <div class="settings-box" on-tap="onShowLanguageInputTap_" actionable>
115 $i18n{keyboardShowLanguageAndInput} 117 <div class="start">$i18n{keyboardShowLanguageAndInput}</div>
118 <button class="subpage-arrow" is="paper-icon-button-light"></button>
hcarmona 2016/12/13 18:00:47 subpage-arrow seems a bit odd to me because we're
michaelpg 2016/12/13 23:21:44 Storage management does this (CrOS). I also filed
michaelpg 2016/12/17 07:11:15 See dbeam's replies at crbug.com/673925 -- I think
hcarmona 2016/12/19 20:00:38 Sounds good.
116 </div> 119 </div>
117 </template> 120 </template>
118 <script src="keyboard.js"></script> 121 <script src="keyboard.js"></script>
119 </dom-module> 122 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698