Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2570693004: [sensors](CrOS/Linux) Fix calculations with offset (Closed)

Created:
4 years ago by maksims (do not use this acc)
Modified:
4 years ago
Reviewers:
Mikhail
CC:
chromium-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors](CrOS/Linux) Fix calculations with offset This cl fixes calculations done with offset value. Offset value must be added to a raw value and only then multiplied by a scaling value. The formula is the following: processed value = (raw + offset) * scale BUG=661478 Committed: https://crrev.com/dd28ec07d1c570b21114cfbe2432ce6d3c41f99d Cr-Commit-Position: refs/heads/master@{#438132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M device/generic_sensor/linux/sensor_data_linux.cc View 4 chunks +22 lines, -25 lines 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 3 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
maksims (do not use this acc)
Please take a look
4 years ago (2016-12-13 10:59:55 UTC) #5
Mikhail
lgtm
4 years ago (2016-12-13 11:01:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570693004/1
4 years ago (2016-12-13 11:45:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 11:49:24 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 11:51:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd28ec07d1c570b21114cfbe2432ce6d3c41f99d
Cr-Commit-Position: refs/heads/master@{#438132}

Powered by Google App Engine
This is Rietveld 408576698