DevTools: Do not show heap snapshot comparison when there's just one snapshot.

DevTools: Do not show heap snapshot comparison when there's just one snapshot.

BUG=259297
Committed: https://crrev.com/d37e731c33f638ce7b27b3b58c1e43f810c0bdc4
Cr-Commit-Position: refs/heads/master@{#438696}

[alph, 2016-12-14 00:09:23]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-12-14 00:43:37]

lgtm

https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
(right):

https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js:511:
const option = this._perspectiveSelect.options().find(option => option.value ===
perspectiveIndex);
nit: I'd rather have a perspective option associated with perspective with a
symbol instead of using option values here.

[alph, 2016-12-14 22:38:56]

https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
(right):

https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js:511:
const option = this._perspectiveSelect.options().find(option => option.value ===
perspectiveIndex);
On 2016/12/14 00:43:37, caseq wrote:
> nit: I'd rather have a perspective option associated with perspective with a
> symbol instead of using option values here.

I tried that, and it doesn't seem to make the code more clear. So I'll keep the
current one.

[alph, 2016-12-14 22:39:06]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:39:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:15:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481755146395200, "parent_rev":
"7c0090146105634fb84680822f3625fc2714c31b", "commit_rev":
"90fb8b4bf5a5a626e73aa2c1c57cef66d539a542"}

[commit-bot: I haz the power, 2016-12-15 01:16:02]

Description was changed from

==========
DevTools: Do not show heap snapshot comparison when there's just one snapshot.

BUG=259297
==========

to

==========
DevTools: Do not show heap snapshot comparison when there's just one snapshot.

BUG=259297

Review-Url: https://codereview.chromium.org/2570673005
==========

[commit-bot: I haz the power, 2016-12-15 01:16:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-15 01:18:33]

Description was changed from

==========
DevTools: Do not show heap snapshot comparison when there's just one snapshot.

BUG=259297

Review-Url: https://codereview.chromium.org/2570673005
==========

to

==========
DevTools: Do not show heap snapshot comparison when there's just one snapshot.

BUG=259297

Committed: https://crrev.com/d37e731c33f638ce7b27b3b58c1e43f810c0bdc4
Cr-Commit-Position: refs/heads/master@{#438696}
==========

[commit-bot: I haz the power, 2016-12-15 01:18:34]

Patchset 1 (id:??) landed as
https://crrev.com/d37e731c33f638ce7b27b3b58c1e43f810c0bdc4
Cr-Commit-Position: refs/heads/master@{#438696}