Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2570673005: DevTools: Do not show heap snapshot comparison when there's just one snapshot. (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not show heap snapshot comparison when there's just one snapshot. BUG=259297 Committed: https://crrev.com/d37e731c33f638ce7b27b3b58c1e43f810c0bdc4 Cr-Commit-Position: refs/heads/master@{#438696}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 8 chunks +26 lines, -21 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
alph
4 years ago (2016-12-14 00:09:24 UTC) #2
caseq
lgtm https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js File third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js (right): https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js#newcode511 third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js:511: const option = this._perspectiveSelect.options().find(option => option.value === perspectiveIndex); ...
4 years ago (2016-12-14 00:43:37 UTC) #3
alph
https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js File third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js (right): https://codereview.chromium.org/2570673005/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js#newcode511 third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js:511: const option = this._perspectiveSelect.options().find(option => option.value === perspectiveIndex); On ...
4 years ago (2016-12-14 22:38:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570673005/1
4 years ago (2016-12-14 22:39:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:16:03 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-15 01:18:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d37e731c33f638ce7b27b3b58c1e43f810c0bdc4
Cr-Commit-Position: refs/heads/master@{#438696}

Powered by Google App Engine
This is Rietveld 408576698